lkml.org 
[lkml]   [2014]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH] coredump: fix incomplete core file created when dump_skip was used last
On 10/22, Victor Kamensky wrote:
>
> --- a/fs/coredump.c
> +++ b/fs/coredump.c
> @@ -664,6 +664,14 @@ void do_coredump(const siginfo_t *siginfo)
> if (!dump_interrupted()) {
> file_start_write(cprm.file);
> core_dumped = binfmt->core_dump(&cprm);
> + /*
> + * If last operation was dump_skip with llseek, we need to
> + * truncate file up to f_pos to match expected size.
> + */
> + if (!ispipe &&
> + (cprm.file->f_pos > i_size_read(file_inode(cprm.file))))
> + do_truncate(cprm.file->f_path.dentry,
> + cprm.file->f_pos, 0, cprm.file);
> file_end_write(cprm.file);
> }
> if (ispipe && core_pipe_limit)
>
> May I use your name with Suggested-by tag?

Sure, thanks ;)

I'd suggest to add a simple helper, but I won't insist. And perhaps the
caller can also check "core_dumped" along with !ispipe, but this is
purely cosmetic.

Oleg.



\
 
 \ /
  Last update: 2014-10-23 19:21    [W:0.048 / U:0.532 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site