Messages in this thread Patch in this message |  | | Date | Thu, 23 Oct 2014 19:12:14 +0300 | From | "Michael S. Tsirkin" <> | Subject | [PATCH] virtio_blk: fix race at module removal |
| |
If a device appears while module is being removed, driver will get a callback after we've given up on the major number.
In theory this means this major number can get reused by something else, resulting in a conflict.
To fix, cleanup in reverse order of initialization.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com> --- drivers/block/virtio_blk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c index 56aadbc..adfba9f 100644 --- a/drivers/block/virtio_blk.c +++ b/drivers/block/virtio_blk.c @@ -883,8 +883,8 @@ out_destroy_workqueue: static void __exit fini(void) { - unregister_blkdev(major, "virtblk"); unregister_virtio_driver(&virtio_blk); + unregister_blkdev(major, "virtblk"); destroy_workqueue(virtblk_wq); } module_init(init); -- MST
|  |