Messages in this thread | | | Date | Thu, 23 Oct 2014 20:38:05 +0530 | From | Sudip Mukherjee <> | Subject | Re: [PATCH] block: wrong return value |
| |
On Thu, Oct 23, 2014 at 08:12:06AM -0600, Jens Axboe wrote: > On 10/23/2014 07:20 AM, Sudip Mukherjee wrote: > > while compiling integer err was showing as a set but unused variable. > > elevator_init_fn can be either cfq_init_queue or deadline_init_queue > > or noop_init_queue. > > all three of these functions are returning -ENOMEM if they fail to > > allocate the queue. > > so we should actually be returning the error code rather than > > returning 0 always. > > That does look weird. You need an elevator_put() in the error case, > though, ala: > oops.. sorry i missed that elevator_get in the code. I will send you v2 of the patch.
thanks sudip
> err = e->ops.elevator_init_fn(q, e); > if (err) > elevator_put(e); > > return err; > > > -- > Jens Axboe >
| |