[lkml]   [2014]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] block: wrong return value
On 10/23/2014 07:20 AM, Sudip Mukherjee wrote:
> while compiling integer err was showing as a set but unused variable.
> elevator_init_fn can be either cfq_init_queue or deadline_init_queue
> or noop_init_queue.
> all three of these functions are returning -ENOMEM if they fail to
> allocate the queue.
> so we should actually be returning the error code rather than
> returning 0 always.

That does look weird. You need an elevator_put() in the error case,
though, ala:

err = e->ops.elevator_init_fn(q, e);
if (err)

return err;

Jens Axboe

 \ /
  Last update: 2014-10-23 16:41    [W:0.027 / U:22.884 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site