[lkml]   [2014]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v2] Staging: iio: adc: fix line over 80 characters
On Thu, Oct 23, 2014 at 12:50:00PM +0200, Lars-Peter Clausen wrote:
> On 10/22/2014 06:21 AM, Sudip Mukherjee wrote:
> >On Tue, Oct 21, 2014 at 05:56:47PM -0500, Brian Vandre wrote:
> >>This fixes the 2 warnings:
> >>WARNING: line over 80 characters
> >>
> >please check your patch with --strict option of , and you will get :
> >"Alignment should match open parenthesis" .
> Those checkpatch warnings are suggestions, not hard requirements.
> The idea is to improve code legibility, but if the change has the
> adverse effect the warning can and should be ignored. Also when
> making a change you should keep the existing indention style of a
> file.
> - Lars

I think my patch does follow the style of the original file. If you run --strict
on the whole file you will get many open parenthesis warnings. I believe it does make it slightly
more legibile.

 \ /
  Last update: 2014-10-23 15:21    [W:0.069 / U:4.976 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site