On Wed, Oct 22, 2014 at 09:24:37PM -0500, Eric Rost wrote:> +static int __init skein_generic_mod_init(void)> +{> + return crypto_register_shash(&alg256) || crypto_register_shash(&alg512)> + || crypto_register_shash(&alg1024);Shouldn't it unwind on error?> +}regards,dan carpenter