Messages in this thread |  | | Date | Thu, 23 Oct 2014 00:29:05 +0000 (GMT) | From | Eunbong Song <> | Subject | Re: Re: [PATCH] mips: add arch_trigger_all_cpu_backtrace() function |
| |
>> This patch adds arch_trigger_all_cpu_backtrace() for mips architecture.
> Don't forget your Signed-off-by
I'm sorry fot this.
>> +static void arch_dump_stack(void *info) >> +{ >> + struct pt_regs *regs; >> + >> + regs = get_irq_regs(); >> + >> + if(regs) >> + show_regs(regs); >> + >> + dump_stack(); >> +} >> + >> +void arch_trigger_all_cpu_backtrace(bool include_self) >> +{ >> + smp_call_function(arch_dump_stack, NULL, 1);
> should this call arch_dump_stack directly too if include_self? Currently, in case of mips there is no case include_self is true, so this is not a problem. arch_trigger_all_cpu_backtrace can only be called from trigger_allbutself_cpu_backtrace() in kernel/watchdog.c. But as you said, if the case will be added, we should consider that.
Thanks.
> Cheers > James
|  |