[lkml]   [2014]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v4 6/6] ARM: dts: add RK3288 suspend support

On Tue, Oct 21, 2014 at 4:26 PM, Chris Zhong <> wrote:
> add pmu_intmem node for suspend, add global_pwroff pinctrl.
> The pmu_intmem is used to store the resume code.
> global_pwroff is held low level at work, it would be pull to high
> when entering suspend. PMICs can get this signal, then shut down
> some power rails. So please reference the global_pwroff pinctrl
> as part of the PMIC config.

nit: I would just say to reference this in the board DTS file since
some boards need it. You could imagine this being useful to something
other than a PMIC.

> + pmu_intmem@ff720000 {
> + compatible = "rockchip,rk3288-pmu-sram", "mmio-sram";
> + reg = <0xff720000 0x4000>;

My TRM says this is 4K big. You're specifying 16K here. If it's
really 4K, it should be <0xff720000 0x1000>

 \ /
  Last update: 2014-10-23 02:41    [W:0.110 / U:1.724 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site