Messages in this thread | | | Date | Wed, 22 Oct 2014 13:00:46 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH v2 2/2] fs: proc: Include cma info in proc/meminfo |
| |
On Wed, 22 Oct 2014 19:36:35 +0530 Pintu Kumar <pintu.k@samsung.com> wrote:
> This patch include CMA info (CMATotal, CMAFree) in /proc/meminfo. > Currently, in a CMA enabled system, if somebody wants to know the > total CMA size declared, there is no way to tell, other than the dmesg > or /var/log/messages logs. > With this patch we are showing the CMA info as part of meminfo, so that > it can be determined at any point of time. > This will be populated only when CMA is enabled.
Fair enough.
We should be pretty careful about what we put in meminfo - it's the top-level, most-important procfs file and I expect that quite a lot of userspace reads it with some frequency. We don't want to clutter it up. /proc/vmstat is a suitable place for the less important info which is more kernel developer oriented.
But CMATotal and CMAFree do pass the "should be in meminfo" test, IMO.
| |