lkml.org 
[lkml]   [2014]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/4] mm: introduce mm_forbids_zeropage function
On Wed, 22 Oct 2014 21:45:52 +0200 Dominik Dingel <dingel@linux.vnet.ibm.com> wrote:

> > > +#ifndef mm_forbids_zeropage
> > > +#define mm_forbids_zeropage(X) (0)
> > > +#endif
> >
> > Can we document this please? What it does, why it does it. We should
> > also specify precisely which arch header file is responsible for
> > defining mm_forbids_zeropage.
> >
>
> I will add a comment like:
>
> /*
> * To prevent common memory management code establishing
> * a zero page mapping on a read fault.
> * This function should be implemented within <asm/pgtable.h>.

s/function should be implemented/macro should be defined/

> * s390 does this to prevent multiplexing of hardware bits
> * related to the physical page in case of virtualization.
> */
>
> Okay?

Looks great, thanks.


\
 
 \ /
  Last update: 2014-10-22 22:21    [W:0.078 / U:0.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site