[lkml]   [2014]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v5 1/6] ARM: cygnus: Initial support for Broadcom Cygnus SoC
On 14-10-22 01:22 AM, Arnd Bergmann wrote:
> On Tuesday 21 October 2014 17:11:08 Scott Branden wrote:
>> OK, I will remove the "iProc SoC based Machine types". This was
>> grouping all iProc based SoCs under one menu and parallels what the
>> existing "Broadcom Mobile Soc Support" menu does.
>> I can create another patch removing the "Broadcom Mobile SoC Support"
>> menu if the ARM Maintainer now want all Broadcom devices are supposed to
>> be contained in a single level?
> Sounds good, I missed that other menu going in.
I will add another patch to my set to correct this.
> It can make sense to add 'comment' statements if you want to separate the
> families.
Thanks - I will add this to my patchset.
> I also noticed that there are a few configuration options that at first
> seem pointless: ARCH_BCM_MOBILE_L2_CACHE and ARCH_BCM_MOBILE_SMP. I wonder
> if it ever makes sense to disable these when the common options (CACHE_L2X0
> and SMP) are enabled for another SoC. I'd normally like to see these as
> hidden options that are always on whenever the core support for those
> features is enabled, to avoid confusing users as well as bugs from the
> combinatorial explosion.
I can clean up all but ARCH_BCM_MOBILE_L2_CACHE. This one is
intertwined with SMC support and it looks like they want the option to
turn on and off this feature. This L2/Trustzone support will need to be
cleaned up at a later time. I heard Russell King says the PL310 cache
code will be changing again soon. When I add PL310 Trustzone support
for the Cygnus SoC I can have a look at cleaning it up for the
Mobile/Kona base SoCs at the same time.
> Arnd

 \ /
  Last update: 2014-10-22 20:21    [W:0.027 / U:0.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site