Messages in this thread |  | | Date | Wed, 22 Oct 2014 17:48:13 +0100 | From | Mark Brown <> | Subject | Re: [PATCH v3 4/5] regulator: max77802: Parse regulator operating mode properties |
| |
On Mon, Oct 20, 2014 at 04:47:51PM +0200, Javier Martinez Canillas wrote:
> + char *states[PM_SUSPEND_MAX + 1] = { > + [PM_SUSPEND_MEM] = "regulator-state-mem", > + [PM_SUSPEND_MAX] = "regulator-state-disk", > + };
This still has the same problem as your previous patch with things not being as joined up with the core as they should be. What I'd like to see is that the code to extract the number for each state is in the core and then the drivers just provide a translation function to map from this to the internal modes. [unhandled content-type:application/pgp-signature] |  |