[lkml]   [2014]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v3] ASoC: rockchip-i2s: add MAX98090 support to Kconfig
On Wed, Oct 22, 2014 at 10:59:59AM +0800, Jianqun wrote:

> +config SND_SOC_MAX98090
> + tristate "ASoC support for max98090 driver"
> + depends on I2C && GPIOLIB
> + help
> + Say Y or M here if you want to add support for max98090 codec.

No, you're missing what Lars was saying here - there's already a Kconfig
symbol for the CODEC in the codecs directory, you should add the help
text to that in order to allow the user to enable it. Do this in a
separate patch to making your I2S driver selectable since it's not
directly related code wise.

Please also drop the "ASoC" -> "SoC audio" transition or at least make
it a separate patch.
[unhandled content-type:application/pgp-signature]
 \ /
  Last update: 2014-10-22 13:01    [W:0.097 / U:3.572 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site