[lkml]   [2014]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v5 1/3] power-domain: add power domain drivers for Rockchip platform
On 22 October 2014 10:07, Geert Uytterhoeven <> wrote:
> On Wed, Oct 22, 2014 at 9:58 AM, Ulf Hansson <> wrote:
>> Now, I just realized that while Geert added attach|detach_dev()
>> callbacks for the generic PM domain, those are both "void" callbacks.
>> It means the deferred probe error handling is broken for these
>> callbacks. We should convert the attach_dev() callback into an int, I
>> will cook a patch immediately.
> That was changed in v3:
> - Move calling of the callbacks to a point where dev->pm_domain is
> valid, so the domain parameter is no longer needed,

That's good.

> - Make callbacks return void.

But not this. :-) Sorry, for being too quick in reviewing that time.

Kind regards

 \ /
  Last update: 2014-10-22 11:01    [W:0.056 / U:1.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site