Messages in this thread |  | | Date | Tue, 21 Oct 2014 17:11:08 -0700 | From | Scott Branden <> | Subject | Re: [PATCH v5 1/6] ARM: cygnus: Initial support for Broadcom Cygnus SoC |
| |
On 14-10-20 10:48 PM, Arnd Bergmann wrote: > On Monday 20 October 2014 15:59:45 Scott Branden wrote: >> On 14-10-20 12:55 PM, Arnd Bergmann wrote: >>> On Tuesday 14 October 2014 19:58:51 Scott Branden wrote: >>>> if ARCH_BCM >>>> >>>> +menu "iProc SoC based Machine types" >>>> + config ARCH_BCM_IPROC >>>> + bool >>>> + select ARM_GIC >>>> + select CACHE_L2X0 >>>> + select HAVE_ARM_SCU if SMP >>>> + select HAVE_ARM_TWD if SMP >>>> + select ARM_GLOBAL_TIMER >>>> + >>>> + select CLKSRC_MMIO >>>> + select ARCH_REQUIRE_GPIOLIB >>>> + select ARM_AMBA >>>> + select PINCTRL >>>> + help >>>> + This enables support for systems based on Broadcom IPROC architected SoCs. >>>> + The IPROC complex contains one or more ARM CPUs along with common >>>> + core periperals. Application specific SoCs are created by adding a >>>> + uArchitecture containing peripherals outside of the IPROC complex. >>>> + Currently supported SoCs are Cygnus. >>>> + >>>> + config ARCH_BCM_CYGNUS >>>> + bool "Broadcom Cygnus Support" if ARCH_MULTI_V7 >>> >>> You still have a three-level menu structure. Please fix. >> >> Hi Arnd, we have ARCH_BCM->ARCH_BCM_CYGNUS. >> >> ARCH_BCM_IPROC is silent and selected by ARCH_BCM_CYGNUS. This was the >> change made between v3 and v5. >> >> Is there something else to be done here? >> > > You have > > "Broadcom SoC Support" > "iProc SoC based Machine types" > "Broadcom Cygnus Support" OK, I will remove the "iProc SoC based Machine types". This was grouping all iProc based SoCs under one menu and parallels what the existing "Broadcom Mobile Soc Support" menu does. I can create another patch removing the "Broadcom Mobile SoC Support" menu if the ARM Maintainer now want all Broadcom devices are supposed to be contained in a single level? > > Get rid of one of them. > > Arnd >
|  |