Messages in this thread Patch in this message |  | | From | Fabio Estevam <> | Subject | [PATCH] checkpatch: Improve warning message for "needless if" case | Date | Tue, 21 Oct 2014 12:33:44 -0200 |
| |
Break the sentence so that it looks better:
WARNING: debugfs_remove(NULL) is safe. This check is probably not required
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index d94f5d8..99653bb 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -4446,7 +4446,7 @@ sub process { my $expr = '\s*\(\s*' . quotemeta($1) . '\s*\)\s*;'; if ($line =~ /\b(kfree|usb_free_urb|debugfs_remove(?:_recursive)?)$expr/) { WARN('NEEDLESS_IF', - "$1(NULL) is safe this check is probably not required\n" . $hereprev); + "$1(NULL) is safe. This check is probably not required\n" . $hereprev); } } -- 1.9.1
|  |