Messages in this thread |  | | Date | Tue, 21 Oct 2014 08:48:51 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH] cmpxchg: Discard unnecessary cast to volatile |
| |
On 10/21/2014 03:14 AM, Peter Zijlstra wrote: > On Mon, Oct 20, 2014 at 04:22:27PM -0400, Pranith Kumar wrote: >>> Generating a volatile pointer is really not necessary here. This is the only >>> location where a volatile pointer is being generated for use in asm. >>> >>> This commit removes the unnecessary volatile pointer being created. >>> >>> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com> > > Seems sane enough to me. >
However, it seems like unnecessary churn. Does the volatile hurt in any way?
-hpa
|  |