lkml.org 
[lkml]   [2014]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] mm/cma: Make kmemleak ignore CMA regions
Date
From: Thierry Reding <treding@nvidia.com>

kmemleak will add allocations as objects to a pool. The memory allocated
for each object in this pool is periodically searched for pointers to
other allocated objects. This only works for memory that is mapped into
the kernel's virtual address space, which happens not to be the case for
most CMA regions.

Furthermore, CMA regions are typically used to store data transferred to
or from a device and therefore don't contain pointers to other objects.

Signed-off-by: Thierry Reding <treding@nvidia.com>
---
Note: I'm not sure this is really the right fix. But without this, the
kernel crashes on the first execution of the scan_gray_list() because
it tries to access highmem. Perhaps a more appropriate fix would be to
reject any object that can't map to a kernel virtual address?
---
mm/cma.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/mm/cma.c b/mm/cma.c
index 963bc4add9af..349f9266f6d3 100644
--- a/mm/cma.c
+++ b/mm/cma.c
@@ -280,6 +280,7 @@ int __init cma_declare_contiguous(phys_addr_t base,
ret = -ENOMEM;
goto err;
} else {
+ kmemleak_ignore(phys_to_virt(addr));
base = addr;
}
}
--
2.1.2


\
 
 \ /
  Last update: 2014-10-21 14:41    [W:0.028 / U:4.728 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site