lkml.org 
[lkml]   [2014]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 8/9] ARM: berlin: Add phy-connection-type to BG2Q PHY
    Hello.

    On 10/21/2014 12:53 PM, Sebastian Hesselbarth wrote:

    > From: Antoine Ténart <antoine.tenart@free-electrons.com>

    > Internal FastEthernet PHY on BG2Q is connected via MII, add a
    > corresponding phy-connection-type property.

    > Tested-by: Antoine Ténart <antoine.tenart@free-electrons.com>
    > Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
    > ---
    > Cc: "David S. Miller" <davem@davemloft.net>
    > Cc: "Antoine Ténart" <antoine.tenart@free-electrons.com>
    > Cc: Florian Fainelli <f.fainelli@gmail.com>
    > Cc: Eric Miao <eric.y.miao@gmail.com>
    > Cc: Haojian Zhuang <haojian.zhuang@gmail.com>
    > Cc: linux-arm-kernel@lists.infradead.org
    > Cc: netdev@vger.kernel.org
    > Cc: devicetree@vger.kernel.org
    > Cc: linux-kernel@vger.kernel.org
    > ---
    > arch/arm/boot/dts/berlin2q.dtsi | 1 +
    > 1 file changed, 1 insertion(+)

    > diff --git a/arch/arm/boot/dts/berlin2q.dtsi b/arch/arm/boot/dts/berlin2q.dtsi
    > index 891d56b03922..6dbc520bddc1 100644
    > --- a/arch/arm/boot/dts/berlin2q.dtsi
    > +++ b/arch/arm/boot/dts/berlin2q.dtsi
    > @@ -127,6 +127,7 @@
    > status = "disabled";
    >
    > ethphy0: ethernet-phy@0 {
    > + phy-connection-type = "mii";

    You're adding this prop to the PHY node? That's very weird... normally,
    it's a property of a MDIO bus node.

    [...]

    WBR, Sergei

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2014-10-21 13:41    [W:3.179 / U:0.524 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site