Messages in this thread |  | | Date | Tue, 21 Oct 2014 20:27:38 +0900 | From | Masami Hiramatsu <> | Subject | Re: Re: [RFC PATCH 5/5] module: Remove stop_machine from module unloading |
| |
(2014/10/13 13:40), Rusty Russell wrote: >> +/* >> + * MODULE_REF_BASE must be 1, since we use atomic_inc_not_zero() for >> + * recovering refcnt (see try_release_module_ref() ). >> + */ >> +#define MODULE_REF_BASE 1 > > True, but we could use atomic_add_unless() instead, and make this > completely generic, right?
Ah, I got it. You might mean replacing atomic_inc_not_zero() in try_release_module_ref with atomic_add_unless(), then we don't need to make MODULE_REF_BASE=1, is that right?
Thank you,
-- Masami HIRAMATSU Software Platform Research Dept. Linux Technology Research Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com
|  |