Messages in this thread | | | Date | Tue, 21 Oct 2014 16:03:36 +0530 | From | Vinod Koul <> | Subject | Re: [PATCH 1/2] mtd: atmel_nand: use __iowrite32_copy for 32 bit copy |
| |
On Tue, Oct 21, 2014 at 06:03:24PM +0800, Josh Wu wrote: > Hi, Vinod > > On 10/21/2014 12:06 AM, Vinod Koul wrote: > >The driver was also using own method to do 32bit copy, turns out > >we have a kernel API so use that instead > > > >Signed-off-by: Vinod Koul <vinod.koul@intel.com> > > Thanks for the patch. > Acked-by: Josh Wu <josh.wu@atmel.com> > > BTW, is there any similar kernel API that is for the read from io? I have not stumbled out on that yet, if someone know of it pls yell!! If there seems to be lack of it, I would suggest we add a similar API in core like __iowrite32_copy()
-- ~Vinod
> > Best Regards, > Josh Wu > > >--- > > drivers/mtd/nand/atmel_nand.c | 10 +++------- > > 1 files changed, 3 insertions(+), 7 deletions(-) > > > >diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c > >index e321c56..b03e80d 100644 > >--- a/drivers/mtd/nand/atmel_nand.c > >+++ b/drivers/mtd/nand/atmel_nand.c > >@@ -265,14 +265,10 @@ static void memcpy32_fromio(void *trg, const void __iomem *src, size_t size) > > *t++ = readl_relaxed(s++); > > } > >-static void memcpy32_toio(void __iomem *trg, const void *src, int size) > >+static inline void memcpy32_toio(void __iomem *trg, const void *src, int size) > > { > >- int i; > >- u32 __iomem *t = trg; > >- const u32 *s = src; > >- > >- for (i = 0; i < (size >> 2); i++) > >- writel_relaxed(*s++, t++); > >+ /* __iowrite32_copy use 32bit size values so divide by 4 */ > >+ __iowrite32_copy(trg, src, size/4); > > } > > /* >
--
| |