Messages in this thread |  | | From | Andy Lutomirski <> | Date | Mon, 20 Oct 2014 21:02:02 -0700 | Subject | Re: [PATCH] init: Remove CONFIG_INIT_FALLBACK |
| |
On Mon, Oct 20, 2014 at 8:45 PM, Rob Landley <rob@landley.net> wrote: > On 10/20/14 17:04, Andy Lutomirski wrote: >> --- a/init/main.c >> +++ b/init/main.c >> @@ -960,13 +960,8 @@ static int __ref kernel_init(void *unused) >> ret = run_init_process(execute_command); >> if (!ret) >> return 0; >> -#ifndef CONFIG_INIT_FALLBACK >> panic("Requested init %s failed (error %d).", >> execute_command, ret); >> -#else >> - pr_err("Failed to execute %s (error %d). Attempting defaults...\n", >> - execute_command, ret); >> -#endif >> } >> if (!try_to_run_init_process("/sbin/init") || >> !try_to_run_init_process("/etc/init") || >> > > Would you like to remove the try_to_run_init_process() stack of random > hardwired names that we can never reach if we panic, or do you just want > to remove the error message? >
I'm confused. That code is reachable if there's no initramfs and init= is not specified.
--Andy
> Confused, > > Rob
-- Andy Lutomirski AMA Capital Management, LLC
|  |