Messages in this thread | | | Date | Mon, 20 Oct 2014 20:46:59 -0400 | From | Prarit Bhargava <> | Subject | Re: [PATCH] scripts, checkpatch.pl, provide a better output message for commit id format [v2] |
| |
On 10/20/2014 07:11 PM, Joe Perches wrote: > On Mon, 2014-10-20 at 18:49 -0400, Prarit Bhargava wrote: >> I tested this using both lower and upper case 'c' with the following commit >> text: > [] > > I think the patch subject be something like: > > "[PATCH] checkpatch: improve commit id/desc style checking in commit message" > > The [v2] goes in the subject like this: > > "[PATCH V2] checkpatch: ..." > >> 11 chars, SHOULD FAIL >> commit 1234567890a > > [] > >> ERROR: Please use 12 or more chars for the git commit ID >> commit 1234567890a > > I'd expect these messages to mention something about the > missing commit description too.
Hmm ... is that a requirement here? Currently checkpatch.pl doesn't complain about that. I can do it but I'd hate to find out that I'm ERRORing on something that is considered okay to do.
P.
> >
| |