Messages in this thread | | | Date | Mon, 20 Oct 2014 20:56:41 +0100 | From | Mark Brown <> | Subject | Re: [PATCH v2 2/2] ARM: EXYNOS: Call regulator core suspend prepare and finish functions |
| |
On Mon, Oct 20, 2014 at 09:50:57PM +0200, Javier Martinez Canillas wrote: > On 10/20/2014 07:36 PM, Doug Anderson wrote:
> > I guess I was just trying to follow the suggestion that was in the > > regulator code: > > http://lxr.free-electrons.com/source/drivers/regulator/core.c#L3699 > > that says "This will usually be called by machine suspend code prior > > to supending."
> I see, but still I feel as if it may be a lot of duplication since most > platforms will likely want to call the regulator core suspend prepare
Note that architectures are an example of a platform. It really depends what's responsible for final poweroff, we want this called as late as we possibly can.
> and finish functions. Maybe it can be added as a Kconfig option so each > platform can choose at the config level if they want those to be called?
No, that's obviously not going to do anything useful for multiplatform. [unhandled content-type:application/pgp-signature] | |