Messages in this thread | | | Date | Mon, 20 Oct 2014 14:53:21 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH 1/2] kprobes: introduce ARCH_HANDLES_KPROBES_ON_FTRACE |
| |
On Mon, 20 Oct 2014 10:55:30 +0900 Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> wrote:
> Hmm, this looks a bit not straight. Maybe we'd better introduce a local > check_ftrace_location() function which always returns 0 if > CONFIG_ARCH_HANDLES_KPROBES_ON_FTRACE(with a comment! :)) as below. > > int check_ftrace_location(kp) > { > unsigned long ftrace_address; > > /* If an architecture handles kprobes on ftrace, we don't check it */ > if (IS_ENABLED(CONFIG_ARCH_HANDLES_KPROBES_ON_FTRACE)) > return 0; > > ... > }
We can also just make that function weak, and let the archs override the default behavior?
-- Steve
| |