lkml.org 
[lkml]   [2014]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/8] perf, tools: Support source line numbers in annotate
On Mon, Oct 20, 2014 at 08:06:05PM +0200, Jiri Olsa wrote:

SNIP

> > + if (dl->line_nr && annotate_browser__opts.show_linenr)
> > + printed = scnprintf(bf, sizeof(bf), "%*s %-5d ",
> > + ab->addr_width, " ", dl->line_nr);
> > + else
> > + printed = scnprintf(bf, sizeof(bf), "%*s ",
> > ab->addr_width, " ");
> > slsmg_write_nstring(bf, printed);
> > slsmg_write_nstring(dl->line, width - printed - pcnt_width + 1);
> > @@ -733,6 +738,7 @@ static int annotate_browser__run(struct annotate_browser *browser,
> > "o Toggle disassembler output/simplified view\n"
> > "s Toggle source code view\n"
> > "/ Search string\n"
> > + "k Toggle line numbers\n"
>
> extra tab --------^^^^^^ making the text misaligned in the help box

also by pressing 'k' the current line jumps to
the hottest line, which does not seem right

jirka


\
 
 \ /
  Last update: 2014-10-20 20:41    [W:0.339 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site