lkml.org 
[lkml]   [2014]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 3/3] i2c/at91: adopt pinctrl support
    Date
    Wenyou Yang <wenyou.yang@atmel.com> writes:

    > Amend the i2c at91 pin controller to optionally take a pin control
    > handle and set the state of the pins to:
    >
    > - "default" on boot, resume and before performing an transfer
    > - "sleep" on suspend()
    >
    > This should make it possible to optimize energy usage for the pins
    > both for the suspend/resume cycle
    >
    > Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>

    This patch is a good example of why you should just have the ->suspend
    function call the same function as ->runtime_suspend.

    If you do that, rather than having to add the pinctrl_pm* calls bo both
    system PM and runtime PM functions, you could've just added them to the
    runtime PM functions.

    Kevin


    \
     
     \ /
      Last update: 2014-10-20 20:41    [W:2.267 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site