lkml.org 
[lkml]   [2014]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv8 1/2] pwm: Add Allwinner SoC support
Hi Alexandre,

On 20.10.2014 13:29, Alexandre Belloni wrote:
> Hi,
>
> On 20/10/2014 at 00:22:57 +0300, Vladimir Zapolskiy wrote :
>>> +struct sun4i_pwm_chip {
>>> + struct pwm_chip chip;
>>> + struct clk *clk;
>>> + void __iomem *base;
>>> + struct mutex ctrl_lock;
>>
>> why do you use mutex? I haven't found any blocking subcalls under
>> protection, a spinlock seems to fit better here.
>>
>
> A mutex here will do the right thing. The lock is never taken in
> interrupt context and a mutex is spinning for a few cycles before
> putting the thread to sleep.

and why do you want to put a thread to sleep in context of the driver?

> I'm not sure why you feel a spinlock would be better here.
>

Only because a spinlock is lighter than a mutex.

With best wishes,
Vladimir


\
 
 \ /
  Last update: 2014-10-20 15:41    [W:0.074 / U:0.840 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site