lkml.org 
[lkml]   [2014]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] Documentation: fix vdso_standalone_test_x86 on 32-bit
From
Date
Peter Foley schreef op wo 08-10-2014 om 15:49 [-0400]:
> vdso_standalone_test_x86 needs -lgcc_s to build succesfully on 32bit.
>
> Signed-off-by: Peter Foley <pefoley2@pefoley.com>
> ---
> Documentation/vDSO/Makefile | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/vDSO/Makefile b/Documentation/vDSO/Makefile
> index 2b99e57..5e5ad9f 100644
> --- a/Documentation/vDSO/Makefile
> +++ b/Documentation/vDSO/Makefile
> @@ -10,3 +10,6 @@ always := $(hostprogs-y)
> HOSTCFLAGS := -I$(objtree)/usr/include -std=gnu99
> HOSTCFLAGS_vdso_standalone_test_x86.o := -fno-asynchronous-unwind-tables -fno-stack-protector
> HOSTLOADLIBES_vdso_standalone_test_x86 := -nostdlib
> +ifeq($(CONFIG_X86_32),y)
> +HOSTLOADLIBES_vdso_standalone_test_x86 += -lgcc_s
> +endif

Applying this patch on top of v3.18-rc1 to get it to build for 32 bit
x86 triggers this build error (when calling "make -s mrproper", which is
done early in the build of a Fedora kernel rpm):
Documentation/vDSO/Makefile:13: *** missing separator. Stop.
make[1]: *** [Documentation/vDSO] Error 2
make: *** [_clean_Documentation] Error 2

Using
ifeq ($(CONFIG_X86_32),y)

fixes that error. And with that space added this patch unbreaks the
build of v3.18-rc1 for 32 bit x86.

Thanks,


Paul Bolle



\
 
 \ /
  Last update: 2014-10-20 14:41    [W:0.046 / U:0.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site