lkml.org 
[lkml]   [2014]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [BUG] perf tools: off-by-one error in map_groups__find_ams()
On Wed, Oct 01, 2014 at 09:16:31PM +0200, Stephane Eranian wrote:
> Hi,
>
> It appears that there is a off-by-one bug in map_groups__find_ams().
> The upper-bound check in the test below should be >= because
> end = start + len; The end address is outside the range.
>
> Please confirm.
>
>
> int map_groups__find_ams(struct addr_map_symbol *ams, symbol_filter_t filter)
> {
> if (ams->addr < ams->map->start || ams->addr > ams->map->end) {

yep, looks like bug to me

jirka


\
 
 \ /
  Last update: 2014-10-02 11:21    [W:0.158 / U:0.808 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site