Messages in this thread | | | Date | Thu, 2 Oct 2014 14:09:45 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH] acct: fix build warning when ACCT_VERSION != 3 |
| |
On Thu, 2 Oct 2014 00:06:53 +0100 Luis Henriques <luis.henriques@canonical.com> wrote:
> struct pid_namespace *ns is used only when ACCT_VERSION is 3. > > kernel/acct.c:475:24: warning: unused variable 'ns' [-Wunused-variable] > > Signed-off-by: Luis Henriques <luis.henriques@canonical.com> > --- > kernel/acct.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/kernel/acct.c b/kernel/acct.c > index b4c667d22e79..5f277f5c5e29 100644 > --- a/kernel/acct.c > +++ b/kernel/acct.c > @@ -472,7 +472,9 @@ static void do_acct_process(struct bsd_acct_struct *acct) > acct_t ac; > unsigned long flim; > const struct cred *orig_cred; > +#if ACCT_VERSION == 3 > struct pid_namespace *ns = acct->ns; > +#endif > struct file *file = acct->file; > > /*
It's always a good idea to check linux-next. This has been addressed by http://ozlabs.org/~akpm/mmots/broken-out/acct-eliminate-compile-warning.patch http://ozlabs.org/~akpm/mmots/broken-out/acct-eliminate-compile-warning-fix.patch
| |