Messages in this thread | | | Date | Thu, 2 Oct 2014 21:59:03 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH] mm: mempolicy: Skip inaccessible VMAs when setting MPOL_MF_LAZY |
| |
On Thu, Oct 02, 2014 at 08:17:03PM +0100, Mel Gorman wrote: > PROT_NUMA VMAs are skipped to avoid problems distinguishing between > present, prot_none and special entries. MPOL_MF_LAZY is not visible from > userspace since commit a720094ded8c ("mm: mempolicy: Hide MPOL_NOOP and > MPOL_MF_LAZY from userspace for now") but it should still skip VMAs the > same way task_numa_work does. > > Signed-off-by: Mel Gorman <mgorman@suse.de> > Acked-by: Rik van Riel <riel@redhat.com>
Acked-by: Peter Zijlstra <peterz@infradead.org>
> --- > mm/mempolicy.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > index 8f5330d..a5877ce 100644 > --- a/mm/mempolicy.c > +++ b/mm/mempolicy.c > @@ -683,7 +683,9 @@ queue_pages_range(struct mm_struct *mm, unsigned long start, unsigned long end, > } > > if (flags & MPOL_MF_LAZY) { > - change_prot_numa(vma, start, endvma); > + /* Similar to task_numa_work, skip inaccessible VMAs */ > + if (vma->vm_flags & (VM_READ | VM_EXEC | VM_WRITE)) > + change_prot_numa(vma, start, endvma); > goto next; > } >
| |