Messages in this thread | | | Subject | Re: [PATCH] x86, MCE, AMD: save IA32_MCi_STATUS before machine_check_poll() resets it | From | Chen Yucong <> | Date | Thu, 02 Oct 2014 22:37:12 +0800 |
| |
On Thu, 2014-10-02 at 15:12 +0200, Borislav Petkov wrote: > > Ok, this return is still bugging me - we're logging the error which > caused the counter overflow but we go and explicitly clear _STATUS so > that machine_check_poll doesn't pick up the same error again. > > Even though, machine_check_poll is intended to log the thresholding > error. > > Which actually makes me think that that machine_check_poll is actually > completely useless there. IOW, how about that instead:
amd_threshold_interrup() is just used for logging threshold events. And any 'valid' threshold events can be checked/logged in loop body. Moreover, machine_check_poll() is unable to check additional MCx_MISCi. So I agree with you on this change.
Thanks! cyc
| |