lkml.org 
[lkml]   [2014]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 00/11] perf: Intel Cache QoS Monitoring support
On Wed, 01 Oct, at 02:42:05PM, Andi Kleen wrote:
> Matt Fleming <matt@console-pimps.org> writes:
> >
> > Changes in v2:
> >
> > - Added Jiri Olsa's Acked-by to PATCH 02/11.
> >
> > - Use x86_match_cpu() in intel_cqm_init() and make sure we grab the
> > hotplug lock to prevent races as pointed out by Andi Kleen in
> > PATCH 08/11.
> >
> > - Delete a stale comment in commit message of PATCH 10/11.
>
> No support for a modular driver?

I didn't include support for that because none of the other x86 pmu
drivers are buildable as modules. Is there a reason for that?

It's not clear to me that it would be a worthwhile change to make this
buildable as a module, since that would require a Kconfig entry and the
user would be required to make a decision regarding whether or not they
want to build CQM support.

It's much simpler to just build it in and enable it based on
CONFIG_PERF_EVENTS + CONFIG_INTEL_CPU. In fact, that's one of the things
I've always liked about the pmu drivers, if I move to a new machine and
turn on PERF_EVENTS the correct drivers will be run.

--
Matt Fleming, Intel Open Source Technology Center


\
 
 \ /
  Last update: 2014-10-02 09:21    [W:0.139 / U:0.432 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site