Messages in this thread | | | Date | Thu, 2 Oct 2014 15:46:06 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH v3.1 1/5] perf report: Set callchain_param.record_mode for future use |
| |
On Thu, Oct 02, 2014 at 12:12:14PM +0900, Namhyung Kim wrote: > Normally the callchain_param.record_mode is used only for record path. > But as it might need to prepare something for dwarf unwinding, setup > this info for perf report too. > > Cc: Jiri Olsa <jolsa@redhat.com> > Cc: David Ahern <dsahern@gmail.com> > Cc: Jean Pihet <jean.pihet@linaro.org> > Cc: Frederic Weisbecker <fweisbec@gmail.com> > Signed-off-by: Namhyung Kim <namhyung@kernel.org> > --- > tools/perf/builtin-report.c | 6 ++++++ > tools/perf/tests/dwarf-unwind.c | 3 +++ > tools/perf/util/callchain.h | 2 ++ > tools/perf/util/hist.h | 2 -- > 4 files changed, 11 insertions(+), 2 deletions(-) > > diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c > index ac145fae0521..495168e73d4a 100644 > --- a/tools/perf/builtin-report.c > +++ b/tools/perf/builtin-report.c > @@ -257,6 +257,12 @@ static int report__setup_sample_type(struct report *rep) > } > } > > + if (symbol_conf.use_callchain || symbol_conf.cumulate_callchain) { > + if (sample_type & PERF_SAMPLE_REGS_USER)
should we check also for PERF_SAMPLE_STACK_USER? as in machine__resolve_callchain
thanks, jirka
| |