Messages in this thread | | | Date | Thu, 02 Oct 2014 16:14:56 +0300 | From | Tanya Brokhman <> | Subject | Re: [PATCH 2/4] UBI: Fastmap: Calc fastmap size correctly |
| |
On 9/30/2014 1:20 AM, Richard Weinberger wrote: > We need to add fm_sb too. > > Signed-off-by: Richard Weinberger <richard@nod.at> > --- > drivers/mtd/ubi/fastmap.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c > index 0431b46..2b0d8d6 100644 > --- a/drivers/mtd/ubi/fastmap.c > +++ b/drivers/mtd/ubi/fastmap.c > @@ -24,7 +24,8 @@ size_t ubi_calc_fm_size(struct ubi_device *ubi) > { > size_t size; > > - size = sizeof(struct ubi_fm_hdr) + \ > + size = sizeof(struct ubi_fm_sb) + \ > + sizeof(struct ubi_fm_hdr) + \ > sizeof(struct ubi_fm_scan_pool) + \ > sizeof(struct ubi_fm_scan_pool) + \ > (ubi->peb_count * sizeof(struct ubi_fm_ec)) + \ >
Not sure what's the proper way doing this (Reviewed-by/Acked-by) but I agree this patch is required. I would just elaborate a bit more on the commit message.
Thanks, Tanya Brokhman -- Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
| |