Messages in this thread | | | Date | Sun, 19 Oct 2014 15:45:51 +0200 | From | Johan Hovold <> | Subject | Re: [3.16.1 BISECTED REGRESSION]: Simtec Entropy Key (cdc-acm) broken in 3.16 |
| |
On Fri, Oct 17, 2014 at 02:21:35PM +0100, Nix wrote: > On 14 Oct 2014, Johan Hovold outgrape: > > Another thing you could try is to add back the > > > > acm_set_control(acm, 0); > > > > just after the dev_info message in probe. > > "Add back" suggests that this line existed before this change. It > didn't, as far as I can see. Probing has > > acm_set_control(acm, acm->ctrlout); > > *shutdown* has > > acm_set_control(acm, acm->ctrlout = 0); > > Did you mean that I should try adding back the acm_set_control() during > shutdown, or the one during probe?
After the dev_info in probe as I wrote. acm->ctrlout will always be 0 at that point, could have been more clear about that.
Johan
| |