lkml.org 
[lkml]   [2014]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH resend] [media] rc-core: fix protocol_change regression in ir_raw_event_register
From
On Sat, Oct 18, 2014 at 9:18 PM, Mauro Carvalho Chehab
<m.chehab@samsung.com> wrote:
>
> The right behavior here is to enable the protocol as soon as the
> new keycode table is written by userspace.
>
> Except for LIRC and the protocol of the current table enabled is
> not a good idea because:
>
> 1) It misread the code from some other IR;
> 2) It will be just spending power without need, running
> several tasks (one for each IR type) with no reason, as the
> keytable won't match the codes for other IRs (and if it is
> currently matching, then this is a bad behavior).
>
I agree, it sounds overkill to have all protocols enabled by default.
I'll make a new patch that enables lirc but disables other protocols
during registration.

Tomas


\
 
 \ /
  Last update: 2014-10-19 12:21    [W:0.090 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site