Messages in this thread | | | Subject | Re: [PATCH 1/2] binfmt_misc: add comments & debug logs | From | Joe Perches <> | Date | Sun, 19 Oct 2014 17:41:58 -0700 |
| |
On Sun, 2014-10-19 at 19:03 -0400, Mike Frysinger wrote: > let's deploy extensive pr_debug markers at > logical parse points, and add comments to the dense parsing logic. [] > diff --git a/fs/binfmt_misc.c b/fs/binfmt_misc.c [] > @@ -259,14 +270,17 @@ static char * check_special_flags (char * sfs, Node * e) > while (cont) { > switch (*p) { > case 'P': > + pr_debug("register: flag: P (preserve argv0)");
Missing '\n' newline. Can you please add them as appropriate?
> p++; > e->flags |= MISC_FMT_PRESERVE_ARGV0; > break; > case 'O': > + pr_debug("register: flag: O (open binary)");
etc...
> @@ -292,6 +306,8 @@ static Node *create_entry(const char __user *buffer, size_t count) > char *buf, *p; > char del; > > + pr_debug("register: received %zu bytes", count);
etc...
| |