Messages in this thread | | | Date | Sun, 19 Oct 2014 19:52:17 -0400 | From | Sasha Levin <> | Subject | Re: [PATCH] kernel: use the gnu89 standard explicitly |
| |
On 10/19/2014 04:05 PM, Linus Torvalds wrote: > On Sun, Oct 19, 2014 at 9:07 AM, Sasha Levin <sasha.levin@oracle.com> wrote: >> > gcc5 changes the default standard to c11, rather than gnu89, which >> > makes kernel build unhappy. > Hmm. Just how unhappy does it make it? Maybe we can instead try to > make the build happier with some minimal changes? Or is it really > painful?
The build breakage is easy to fix. I'm worried about the stuff that won't show upon build. Different behaviours that go unnoticed and maybe issues inside gcc's code generation that weren't uncovered until now.
Also, unless we specify exactly what standard we want what would happen is that a significantly different C standard would be used depending on the compiler version. It is already the case with clang but putting in a 3rd one in the mix is too much IMO.
I'll send a few other patches to make it at least compile under c11, but I still think that we should plug this hole by sticking with gnu89 for now.
Thanks, Sasha
| |