Messages in this thread | | | Date | Sun, 19 Oct 2014 19:28:07 +0200 | From | Manfred Schlaegl <> | Subject | Re: [PATCH] um: Remove unused bp stack-frame pointer |
| |
On 2014-10-18 17:40, Richard Weinberger wrote: > Am 18.10.2014 um 17:24 schrieb Manfred Schlaegl: >> On 2014-10-18 17:19, Richard Weinberger wrote: >>> Am 18.10.2014 um 17:12 schrieb Manfred Schlaegl: >>>> On 2014-10-18 16:42, Richard Weinberger wrote: >>>>> Am 18.10.2014 um 16:23 schrieb Manfred Schlaegl: >>>>>> The pointer to bp stack-frame is no longer used. Removed it. >>>>> >>>>> Good catch! >>>> Thank you. >>>> >>>>> >>>>>> This also removes a corresponding compiler-warning. >>>>> >>>>> Which warning exactly? >>>> >>>> On "normal" (defconfig) builds the warning does not show up because CONFIG_FRAME_POINTER is set. >>>> I've found the unused bp because CONFIG_FRAME_POINTER was not set in my configuration. >>>> >>>> CC arch/um/kernel/sysrq.o >>>> arch/um/kernel/sysrq.c: In function ‘show_stack’: >>>> arch/um/kernel/sysrq.c:32:29: warning: unused variable ‘bp’ [-Wunused-variable] >>> >>> Looks like my gcc need's an upgrade. :D >>> >>> Thanks, >>> //richard >>> >> >> I'm using gcc version 4.7.2 (Debian 4.7.2-5). -> not THAT new ;-) > > With a cup of coffee applied I managed it to read your mail correctly. > The warning triggers only with CONFIG_FRAME_POINTER=n. Now it makes sense.
Misunderstanding solved! Miracle cure caffeine ;-)
greetings manfred
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |