Messages in this thread | | | Date | Sat, 18 Oct 2014 13:50:18 -0700 | Subject | Re: [PATCH] futex: Ensure get_futex_key_refs() always implies a barrier | From | Linus Torvalds <> |
| |
On Sat, Oct 18, 2014 at 12:58 PM, Davidlohr Bueso <dave@stgolabs.net> wrote: > > And [get/put]_futex_keys() shouldn't even be called for private futexes. > The following patch had some very minor testing on a 60 core box last > night, but passes both Darren's and perf's tests. So I *think* this is > right, but lack of sleep and I overall just don't trust them futexes!
Hmm. I don't see the advantage of making the code more complex in order to avoid the functions that are no-ops for the !fshared case?
IOW, as far as I can tell, this patch doesn't actually really *change* anything. Am I missing something?
Linus
| |