Messages in this thread | | | Date | Fri, 17 Oct 2014 09:50:08 +0200 | From | Lee Jones <> | Subject | Re: [PATCH v2 7/7] mfd: ab8500: Decrement the power supply's device reference counter |
| |
On Thu, 16 Oct 2014, Krzysztof Kozlowski wrote:
> On czw, 2014-10-16 at 14:29 +0200, Lee Jones wrote: > > On Thu, 16 Oct 2014, Krzysztof Kozlowski wrote: > > > > > Use power_supply_put() to decrement the power supply's device reference > > > counter. > > > > > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > > > Acked-by: Pavel Machek <pavel@ucw.cz> > > > > I already Acked this. > > I think you acked mfd change in my first patchset > (power_supply_get_property()): > [PATCH 5/8] mfd: ab8500: Use power_supply_*() API for accessing > function attrs > > ... and this is my second patchset with other API (power_supply_put).
Maybe my reply wasn't sent properly (the WiFi at this conference has been pretty shakey at points).
Anyway ... Acked-by: Lee Jones <lee.jones@linaro.org>
> > > --- > > > drivers/mfd/ab8500-sysctrl.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/drivers/mfd/ab8500-sysctrl.c b/drivers/mfd/ab8500-sysctrl.c > > > index 93b2d2c32ca3..d05a5719cfc4 100644 > > > --- a/drivers/mfd/ab8500-sysctrl.c > > > +++ b/drivers/mfd/ab8500-sysctrl.c > > > @@ -51,6 +51,7 @@ static void ab8500_power_off(void) > > > > > > ret = power_supply_get_property(psy, POWER_SUPPLY_PROP_ONLINE, > > > &val); > > > + power_supply_put(psy); > > > > > > if (!ret && val.intval) { > > > charger_present = true; > > > @@ -73,6 +74,7 @@ static void ab8500_power_off(void) > > > pss[i]); > > > machine_restart("charging"); > > > } > > > + power_supply_put(psy); > > > } > > > > > > shutdown: > > >
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |