lkml.org 
[lkml]   [2014]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/4 linux-next] x86, msr: define msr chunksize
On 10/17/2014 01:01 PM, Fabian Frederick wrote:
> define MSR_CHUNK_SIZE instead of hard-coded value (8).
>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>

I don't like the name, as it isn't a "chunk" but the actual width of an MSR.

Furthermore, the last hunk is just plain wrong; the 8 there refers to
the number of registers and not to the width of an MSR.

-hpa



\
 
 \ /
  Last update: 2014-10-17 23:01    [W:0.035 / U:2.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site