lkml.org 
[lkml]   [2014]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v3 1/2] usb: dwc2: gadget: sparse warning of context imbalance
Date
> From: Sudip Mukherjee [mailto:sudipm.mukherjee@gmail.com]
> Sent: Thursday, October 16, 2014 9:44 PM
>
> sparse was giving the following warning:
> warning: context imbalance in 's3c_hsotg_ep_enable'
> - different lock contexts for basic block
>
> we were returning ENOMEM while still holding the spinlock.
> The sparse warning was fixed by releasing the spinlock before return.
>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
> drivers/usb/dwc2/gadget.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
> index 7b5856f..7f25527 100644
> --- a/drivers/usb/dwc2/gadget.c
> +++ b/drivers/usb/dwc2/gadget.c
> @@ -2561,8 +2561,10 @@ static int s3c_hsotg_ep_enable(struct usb_ep *ep,
> hs_ep->fifo_size = val;
> break;
> }
> - if (i == 8)
> - return -ENOMEM;
> + if (i == 8) {
> + ret = -ENOMEM;
> + goto error;
> + }
> }
>
> /* for non control endpoints, set PID to D0 */
> @@ -2579,6 +2581,7 @@ static int s3c_hsotg_ep_enable(struct usb_ep *ep,
> /* enable the endpoint interrupt */
> s3c_hsotg_ctrl_epint(hsotg, index, dir_in, 1);
>
> +error:
> spin_unlock_irqrestore(&hsotg->lock, flags);
> return ret;
> }

Acked-by: Paul Zimmerman <paulz@synopsys.com>



\
 
 \ /
  Last update: 2014-10-17 21:01    [W:0.097 / U:0.336 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site