lkml.org 
[lkml]   [2014]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: + freezer-check-oom-kill-while-being-frozen.patch added to -mm tree
On Fri 17-10-14 17:24:29, Oleg Nesterov wrote:
> On 10/16, Cong Wang wrote:
> >
> > On Thu, Oct 16, 2014 at 3:22 PM, Oleg Nesterov <oleg@redhat.com> wrote:
> > > On 10/16, Cong Wang wrote:
> > >>
> > >> it will always stay in asleep after schedule()?
> > >
> > > Not always. But it will stay asleep in this particular case.
> >
> > Hmm, so we still need to wake it up in oom killer:
> >
> > if (test_tsk_thread_flag(task, TIF_MEMDIE)) {
> > if (unlikely(frozen(task)))
> > wake_up_state(task, TASK_UNINTERRUPTIBLE);
> >
> > I will update the patch if Michal doesn't.
>
> I think it would be better to simply keep that __thaw_task() in
> oom_scan_process_thread().

yeah, v2 of the patch (I guess you were on CC) does exactly this.

Thanks!
--
Michal Hocko
SUSE Labs


\
 
 \ /
  Last update: 2014-10-17 18:41    [W:0.061 / U:2.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site