lkml.org 
[lkml]   [2014]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v11 13/21] ext2: Remove ext2_xip_verify_sb()
On Thu, Oct 16, 2014 at 02:18:02PM +0200, Mathieu Desnoyers wrote:
> On 25-Sep-2014 04:33:30 PM, Matthew Wilcox wrote:
> > Jan Kara pointed out that calling ext2_xip_verify_sb() in ext2_remount()
> > doesn't make sense, since changing the XIP option on remount isn't
> > allowed. It also doesn't make sense to re-check whether blocksize is
> > supported since it can't change between mounts.
>
> By "doesn't make sense", do you mean it is never actually used, or that
> it is possible for a current user to trigger issues by changing XIP
> option on remount ? If it is the case, then this patch should probably
> be flagged as a "Fix".

I mean that we're checking for a condition that can't actually happen,
so it's safe to just delete the check.


\
 
 \ /
  Last update: 2014-10-17 09:42    [W:1.913 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site