Messages in this thread | | | Date | Thu, 16 Oct 2014 18:21:46 -0400 | From | Matthew Wilcox <> | Subject | Re: [PATCH v11 06/21] vfs: Add copy_to_iter(), copy_from_iter() and iov_iter_zero() |
| |
On Thu, Oct 16, 2014 at 02:12:06PM +0000, Mathieu Desnoyers wrote: > > The access_ok() check is done higher up the call-chain if it's appropriate. > > These functions can be (intentionally) called to access kernel addresses, > > so it wouldn't be appropriate to do that here. > > If the access_ok() are expected to be already done higher in the call-chain, > we might want to rename e.g. copy_to_iter_iovec to > __copy_to_iter_iovec(). It helps clarifying the check expectations for the > caller.
I'm following the existing convention in this file; it already had copy_page_to_iter() and copy_page_from_iter() as exported symbols. I just added copy_to_iter() and copy_from_iter().
| |