Messages in this thread | | | Date | Fri, 17 Oct 2014 15:18:00 +0530 | Subject | Re: [PATCH V2 6/6] cpufreq: Loongson1: Add cpufreq driver for Loongson1B | From | Viresh Kumar <> |
| |
On 17 October 2014 13:47, Viresh Kumar <viresh.kumar@linaro.org> wrote: > On 17 October 2014 12:07, Kelvin Cheung <keguang.zhang@gmail.com> wrote: >> V2: >> Use devm_clk_get() instead of clk_get(). > > Search for a few drivers which have used this API and understand how > to use it.
To elaborate it a bit further, devm_* routines are there to make our lives simple. And they do it by allowing us to skip error handling.
So in your case because you are doing devm_clk_get(), you don't have to put the clk on errors or in remove() routine. The device core will do that for you once the device/driver bond finishes.
Also, what about clk_enable/prepare for these clks? You don't need them ?
-- viresh
| |