Messages in this thread Patch in this message | | | From | Sudip Mukherjee <> | Subject | [PATCH v2 2/2] usb: dwc2: gadget: sparse warning of context imbalance | Date | Thu, 16 Oct 2014 13:11:10 +0530 |
| |
sparse was giving the following warning: warning: context imbalance in 's3c_hsotg_ep_enable' - different lock contexts for basic block
we were returning ENOMEM while still holding the spinlock. The sparse warning was fixed by releasing the spinlock before return.
This patch depends on the previous patch of the series.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> --- drivers/usb/dwc2/gadget.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index af5517f..05a9a23 100644 --- a/drivers/usb/dwc2/gadget.c +++ b/drivers/usb/dwc2/gadget.c @@ -2564,7 +2564,7 @@ static int s3c_hsotg_ep_enable(struct usb_ep *ep, } if (i == 8) { ret = -ENOMEM; - goto error1; + goto error2; } } @@ -2582,6 +2582,7 @@ static int s3c_hsotg_ep_enable(struct usb_ep *ep, /* enable the endpoint interrupt */ s3c_hsotg_ctrl_epint(hsotg, index, dir_in, 1); +error2: spin_unlock_irqrestore(&hsotg->lock, flags); error1: -- 1.8.1.2
| |